Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-97850: Remove the mention of removal from ResourceReader docs #128602

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Jan 7, 2025

There is currently no plan to remove ResourceReader, especially given that the suggested alternative TraversableResources inherits from ResourceReader. Let's remove the mention of a removal for now.

Related discussion: #97850 (comment)


📚 Documentation preview 📚: https://cpython-previews--128602.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir awaiting review labels Jan 7, 2025
@tomasr8 tomasr8 added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jan 8, 2025
@hugovk
Copy link
Member

hugovk commented Jan 8, 2025

Also remove mention of removal from https://github.com/python/cpython/blob/main/Doc/deprecations/pending-removal-in-3.14.rst?

@tomasr8
Copy link
Member Author

tomasr8 commented Jan 8, 2025

Also remove mention of removal from https://github.com/python/cpython/blob/main/Doc/deprecations/pending-removal-in-3.14.rst?

Yes, I missed that one. I'll update the PR in a bit!

@StanFromIreland
Copy link
Contributor

@tomasr8 Done for you :)

@tomasr8
Copy link
Member Author

tomasr8 commented Jan 8, 2025

Oh wait, that is the other ResourceReader that was actually removed in 3.14 (from importlib.abc). This PR updates the one in importlib.resources.abc which still exists. So there should be no need to update that document you mentioned Hugo.

Sorry for the confusion @StanFromIreland, I should've checked better :/ but thanks for the help!

@brettcannon brettcannon removed their request for review January 8, 2025 21:00
@tomasr8 tomasr8 requested a review from jaraco January 8, 2025 22:12
@jaraco jaraco merged commit a1284e9 into python:main Jan 8, 2025
40 checks passed
@miss-islington-app
Copy link

Thanks @tomasr8 for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2025
…ocs (pythonGH-128602)

Remove the mention of removal from ResourceReader docs
(cherry picked from commit a1284e9)

Co-authored-by: Tomas R. <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2025
…ocs (pythonGH-128602)

Remove the mention of removal from ResourceReader docs
(cherry picked from commit a1284e9)

Co-authored-by: Tomas R. <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 8, 2025

GH-128654 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 8, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 8, 2025

GH-128655 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jan 8, 2025
@bedevere-bot

This comment was marked as off-topic.

@tomasr8
Copy link
Member Author

tomasr8 commented Jan 9, 2025

The buildbot failure is unrelated (it's in test_multiprocessing_forkserver while this PR only touches the docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants