gh-129027: Raise DeprecationWarning for sys._clear_type_cache #129043
+24
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Jan 20, 2025
sobolevn
reviewed
Jan 20, 2025
tomasr8
reviewed
Jan 20, 2025
There was a problem hiding this comment.
sys._clear_type_cache is used in other tests as well which will now raise a DeprecationWarning. I think we should suppress the warnings in the relevant tests (or maybe switch to sys._clear_internal_caches()? though that might make backporting tests to 3.12 more difficult since the function was added in 3.13)
|
This will also require a news entry :) |
tomasr8
reviewed
Jan 21, 2025
Co-authored-by: Tomas R. <[email protected]>
Co-authored-by: Tomas R. <[email protected]>
Co-authored-by: Tomas R. <[email protected]>
tomasr8
reviewed
Jan 21, 2025
picnixz
reviewed
Jan 23, 2025
picnixz
reviewed
Jan 23, 2025
| @@ -0,0 +1 @@ | |||
| Raise DeprecationWarning for :func:`sys._clear_type_cache` | |||
There was a problem hiding this comment.
We could also have a What's New entry as well, not just a NEWS entry. You could also mention that this function was deprecated since 3.13 but didn't raise a deprecation warning at runtime.
Co-authored-by: Bénédikt Tran <[email protected]>
picnixz
reviewed
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeprecationWarningforsys._clear_type_cache#129027