Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-129223: Do not allow the compiler to optimise away symbols for debug sections #129225

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jan 23, 2025

@@ -414,7 +414,11 @@ get_py_runtime(pid_t pid)
static uintptr_t
get_async_debug(pid_t pid)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is to avoid returning NULL without an error set as things under search_map_for_section may return without setting an error.

@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2025
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2025
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2025
@python python deleted a comment from bedevere-bot Jan 23, 2025
@pablogsal pablogsal added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jan 23, 2025
@pablogsal pablogsal force-pushed the gh-129223 branch 3 times, most recently from 3bfb5f7 to 170075a Compare January 23, 2025 14:42
@pablogsal pablogsal added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jan 23, 2025
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2025
@python python deleted a comment from bedevere-bot Jan 23, 2025
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2025
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2025
@python python deleted a comment from bedevere-bot Jan 23, 2025
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2025
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2025
@python python deleted a comment from bedevere-bot Jan 23, 2025
@python python deleted a comment from bedevere-bot Jan 23, 2025
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit bd41fda 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2025
@JacobCoffee JacobCoffee added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @JacobCoffee for commit bd41fda 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2025
@ambv ambv added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jan 23, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ambv for commit bd41fda 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2025
@ambv
Copy link
Contributor

ambv commented Jan 23, 2025

!buildbot aarch64 Fedora Stable Clang

@python python deleted a comment from bedevere-bot Jan 23, 2025
@python python deleted a comment from bedevere-bot Jan 23, 2025
@python python deleted a comment from bedevere-bot Jan 24, 2025
@python python deleted a comment from ambv Jan 24, 2025
@python python deleted a comment from bedevere-bot Jan 24, 2025
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 24, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 596a58f 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 24, 2025
@ambv
Copy link
Contributor

ambv commented Jan 24, 2025

The test_interpreters.test_create_many_threaded failure looks unrelated to me, it's a failure to import encodings in one of the sub-interpreters on a thread:
https://buildbot.python.org/#/builders/1255/builds/370/steps/6/logs/stdio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants