Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare changelog for 1.15 release #18583

Merged
merged 7 commits into from
Feb 4, 2025
Merged

Prepare changelog for 1.15 release #18583

merged 7 commits into from
Feb 4, 2025

Conversation

wesleywright
Copy link
Collaborator

No description provided.

@wesleywright wesleywright mentioned this pull request Feb 1, 2025
5 tasks
CHANGELOG.md Outdated

Thanks to all mypy contributors who contributed to this release:

​Thanks to all mypy contributors who contributed to this release:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate sentence

CHANGELOG.md Outdated
* Improve security of our GitHub Actions (sobolevn, PR [18413](https://github.com/python/mypy/pull/18413))
* Unwrap `type[Union[...]]` when solving typevar constraints (Stanislav Terliakov, PR [18266](https://github.com/python/mypy/pull/18266))
* Allow `Any` to match sequence patterns in match/case (Stanislav Terliakov, PR [18448](https://github.com/python/mypy/pull/18448))
* Avoid false `unreachable` and `redundant-expr` warnings in loops. (Christoph Tyralla, PR [18433](https://github.com/python/mypy/pull/18433))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18433 covered in highlights

CHANGELOG.md Outdated
Comment on lines 155 to 157
* Speed up `State.finish_passes` (Jukka Lehtosalo, PR [18302](https://github.com/python/mypy/pull/18302))
* Optimize type indirection visitor (Jukka Lehtosalo, PR [18298](https://github.com/python/mypy/pull/18298))
* Speed up SCC dependency inference (Jukka Lehtosalo, PR [18299](https://github.com/python/mypy/pull/18299))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could move these to performance highlight

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a pass at this; @JukkaL feel free to stomp over my description of your changes of course (before or after merging).

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments. I will do a more detailed review pass after this has been merged, since it's more efficient for me to make small edits in an editor.

CHANGELOG.md Outdated
@@ -2,6 +2,18 @@

## Next release

...

## Mypy 1.15 (unreleased)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Title Case for section headings (also "Next Release" above), for consistency.

* Ignore `dataclass.__replace__` LSP violations (Marc Mueller, PR [18464](https://github.com/python/mypy/pull/18464))
* Bind `self` to the class being defined when checking multiple inheritance (Stanislav Terliakov, PR [18465](https://github.com/python/mypy/pull/18465))
* Fix attribute type resolution with multiple inheritance (Stanislav Terliakov, PR [18415](https://github.com/python/mypy/pull/18415))
* Improve security of our GitHub Actions (sobolevn, PR [18413](https://github.com/python/mypy/pull/18413))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an internal change and could be left out, though maybe users will be happy to know that we are more secure?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that was my thought; technically it's "public" in that it's an improvement to security for the supply chain for the software they're using (ie, they're less likely to suffer from a supply chain attack). I'm happy to remove it if you want though, just LMK.

CHANGELOG.md Outdated
* Fix iteration over `NamedTuple` objects (Advait Dixit, PR [18254](https://github.com/python/mypy/pull/18254))
* Mark mypyc package with `py.typed` (bzoracler, PR [18253](https://github.com/python/mypy/pull/18253))
* Update docstrings of IR builder classes (Jukka Lehtosalo, PR [18246](https://github.com/python/mypy/pull/18246))
* Fix list index while checking for `Enum` class. (Advait Dixit, PR [18426](https://github.com/python/mypy/pull/18426))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you strip periods at end of change log items, for consistency? (I guess we could do this in the change log generation script as well.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I tried to do this on my first pass, but I missed a couple.

Tangentially related, I kind of love the vim regex for finding these occurrences:

/^ [*].*[.] [(]/

Copy link
Contributor

github-actions bot commented Feb 4, 2025

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@wesleywright wesleywright force-pushed the release-1.15-changelog branch from 85066b8 to 739b57b Compare February 4, 2025 03:27
@JukkaL JukkaL merged commit c30670e into master Feb 4, 2025
30 of 31 checks passed
@JukkaL JukkaL deleted the release-1.15-changelog branch February 4, 2025 14:34
wesleywright added a commit that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants