remove separate tls listen for haproxy #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haproxy has natively supported http/2 for a _long_ time. This listen (combined frontend/backend) was added long ago before haproxy supported http/2 (back when it was called spdy). Drop the http server config for http/2, and move all binds back into the main frontend.
|
basically a long overdue revert of 794c3cc |
JacobCoffee
approved these changes
Dec 18, 2024
ewdurbin
added a commit
that referenced
this pull request
Dec 18, 2024
This condition was in place to support the proxy nonsense we had going that was removed in #543, we can go ahead and always set this now that our frontend is handling tls
ewdurbin
added a commit
that referenced
this pull request
Dec 18, 2024
This condition was in place to support the proxy nonsense we had going that was removed in #543, we can go ahead and always set this now that our frontend is handling tls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haproxy has natively supported http/2 for a long time.
This listen (combined frontend/backend) was added long ago before haproxy supported http/2 (back when it was called spdy).
Drop the http server config for http/2, and move all binds back into the main frontend.