sort allowlists by version more consistently #13160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to ensure that categorization and comments are in sync between one allowlist and another.
With the help of a quick script, I sorted the version-specific allowlists and made sure that comments and fix/don't fix is consistent between the files. Each labeled section is identical to others with the same name, and this should also make consolidating when dropping an old version easier.
On the negative side, this is unfortunately sure to cause a lot of merge conflicts. What do people think? Worth it or not worth it?
There should be no significant differences in overall content in this MR. I did consolidate some comments to an inline version, and there was one entry which had been commented out in all the files where it appeared:
I'm not sure why it was commented out but not removed; I did remove it as part of this MR. Edit: looks like it's from #7442