Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort allowlists by version more consistently #13160

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

tungol
Copy link
Contributor

@tungol tungol commented Nov 30, 2024

This makes it easier to ensure that categorization and comments are in sync between one allowlist and another.

With the help of a quick script, I sorted the version-specific allowlists and made sure that comments and fix/don't fix is consistent between the files. Each labeled section is identical to others with the same name, and this should also make consolidating when dropping an old version easier.

On the negative side, this is unfortunately sure to cause a lot of merge conflicts. What do people think? Worth it or not worth it?

There should be no significant differences in overall content in this MR. I did consolidate some comments to an inline version, and there was one entry which had been commented out in all the files where it appeared:

# typing.SupportsRound.__round__ # pos-or-kw at runtime, but we pretend it's pos-only in the stub so that e.g. float.__round__ satisfies the interface

I'm not sure why it was commented out but not removed; I did remove it as part of this MR. Edit: looks like it's from #7442

This makes it easier to ensure that categorization and comments
are in sync between one allowlist and another.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 1, 2024

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit c713947 into python:main Dec 2, 2024
63 checks passed
@tungol tungol deleted the sort_allowlists branch December 2, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants