Bump django-import-export to 4.3.4 #13414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Viicos
commented
Jan 20, 2025
| @@ -1,9 +1,12 @@ | |||
| from _typeshed import Incomplete, ReadableBuffer | |||
| from logging import Logger | |||
| from typing import IO, Any, ClassVar | |||
| from typing_extensions import Self, TypeAlias | |||
|
|
|||
| Dataset: TypeAlias = Incomplete # tablib.Dataset | |||
There was a problem hiding this comment.
@srittau, as per #12990 (comment), do you think we can do the same here?
There was a problem hiding this comment.
Seems like it doesn't work with pyright, as we make use of the imported symbol in annotations
This comment has been minimized.
This comment has been minimized.
Viicos
force-pushed
the
update-django-import-export
branch
from
e498f5e to
1aa4152
Compare
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13328.
This was tedious but pretty straightforward to do. I went over every PR in https://django-import-export.readthedocs.io/en/stable/changelog.html, and updated the stubs accordingly commit per commit.