This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: This is a start of a cleanup of private casting functions in preparation for rowwise scaling. In this PR: 1. create `float8_scaling_utils.py` to unify functions which take a high precision tensor and return a float8 tensor, taking care of scaling 2. delete `Float8Tensor.to_float8` and move callsites to `ToFloat8ConstrFunc`, since the two functions do the same thing The end result is a slightly cleaner state, future PRs will do more cleanups. Test Plan: ``` ./test/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 30f7160c6751aa8bf82dfa35e9d8449d20a4028d Pull Request resolved: #339
- Loading branch information
Showing
11 changed files
with
310 additions
and
274 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.