This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
[bc-breaking] clarify public API of float8_experimental #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Makes the following functions public: * convert_to_float8_training and all of its configuration * linear_requires_sync * sync_float8_amax_and_scale_history * precompute_float8_dynamic_scale_for_fsdp Everything else is private. The fbsource counterpart of this PR will remove usage of private APIs. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jul 24, 2024
facebook-github-bot
added
the
CLA Signed
vkuzo
added a commit
that referenced
this pull request
Jul 24, 2024
Summary: Makes the following functions public: * convert_to_float8_training and all of its configuration * linear_requires_sync * sync_float8_amax_and_scale_history * precompute_float8_dynamic_scale_for_fsdp Everything else is private. The fbsource counterpart of this PR will remove usage of private APIs. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 923035b9c859659bcb44b145d8609177abe95ce9 Pull Request resolved: #330
weifengpy
approved these changes
Jul 24, 2024
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in a6cef5a. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
convert_to_float8_training#329module_filter_fn#328emulateflag toFloat8LinearConfig#327Summary:
Makes the following functions public:
Everything else is private. The fbsource counterpart of this PR will
remove usage of private APIs.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D60195666