Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use add_violation #34

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Refactor to use add_violation #34

merged 1 commit into from
Mar 15, 2024

Conversation

kit1980
Copy link
Contributor

@kit1980 kit1980 commented Mar 15, 2024

No description provided.

@kit1980 kit1980 requested a review from malfet March 15, 2024 19:55
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 15, 2024
@kit1980 kit1980 marked this pull request as ready for review March 15, 2024 19:56
huydhn
huydhn approved these changes Mar 15, 2024
View reviewed changes
Copy link

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kit1980 kit1980 merged commit 9b5adef into main Mar 15, 2024
2 checks passed
@kit1980 kit1980 deleted the sdym/add_violation branch March 19, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@huydhn huydhn huydhn approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kit1980 @huydhn @malfet @facebook-github-bot