Add check for second value in sum: Logsumexp #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
kit1980
reviewed
Jan 23, 2025
torchfix/visitors/misc/__init__.py
Outdated
| @@ -183,7 +183,7 @@ def visit_Call(self, node): | |||
| node.args[0].value.args[0].value | |||
| ) | |||
| == "torch.exp" | |||
| ): | |||
| ) and len(node.args[0].value.args) > 1 and node.args[0].value.args[1].value is not None: | |||
There was a problem hiding this comment.
Use get_specific_arg from https://github.com/pytorch-labs/torchfix/blob/main/torchfix/common.py#L64 because dim can be passed as a positional or as a keyword argument.
There was a problem hiding this comment.
Updated and added condition to check for dim. But I used has_specific_arg since we just want to check its presence
kit1980
reviewed
Jan 23, 2025
kit1980
reviewed
Jan 23, 2025
kit1980
reviewed
Jan 24, 2025
| message=self.ERRORS[0].message(), | ||
| replacement=None, | ||
| ) | ||
| if len(node.args[0].value.args) > 1 and ( |
There was a problem hiding this comment.
I don't think value.args[1] is always correct, because the order may be different for keyword arguments.
For example, add test y = torch.log(torch.sum(torch.exp(x)), keepdim=True, dim=None).
I think you can delete most if this and just use get_specific_arg("dim", 1), which will return None if the argument is not present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added conditions to check if second value exists in "sum" for Logsumexp update. If not then no change.
Files updated: