Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support adaptive_avg_pool1d dynamo converter #2614

Merged
merged 3 commits into from
Mar 21, 2024
Merged

feat: support adaptive_avg_pool1d dynamo converter #2614

merged 3 commits into from
Mar 21, 2024

Conversation

zewenli98
Copy link
Collaborator

Description

Support adaptive_avg_pool1d dynamo_converter.

Fixes #2603

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jan 21, 2024
@github-actions github-actions bot requested a review from apbose January 21, 2024 15:10
@zewenli98 zewenli98 self-assigned this Jan 23, 2024
@zewenli98 zewenli98 requested a review from narendasan January 23, 2024 14:36
@zewenli98 zewenli98 requested a review from gs-olive February 2, 2024 18:39
gs-olive
gs-olive reviewed Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good and with robust testing. Added a few questions and suggestions for documentation

tests/py/dynamo/conversion/test_adaptive_avgpool_aten.py Show resolved Hide resolved
py/torch_tensorrt/dynamo/conversion/impl/pool.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/conversion/impl/pool.py Outdated Show resolved Hide resolved
@zewenli98 zewenli98 force-pushed the adaptive_avg_pool1d_dynamo_converter branch from 495c981 to 36c927a Compare February 9, 2024 00:37
@zewenli98 zewenli98 requested a review from gs-olive February 9, 2024 23:59
@zewenli98 zewenli98 force-pushed the adaptive_avg_pool1d_dynamo_converter branch from 2595b2a to 84a8092 Compare February 23, 2024 01:56
narendasan
narendasan approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zewenli98 zewenli98 merged commit 3a5c39f into pytorch:main Mar 21, 2024
21 checks passed
peri044 pushed a commit that referenced this pull request Apr 19, 2024
@zewenli98 @peri044
feat: support adaptive_avg_pool1d dynamo converter (#2614)
5930e96
laikhtewari pushed a commit that referenced this pull request May 24, 2024
@zewenli98 @laikhtewari
feat: support adaptive_avg_pool1d dynamo converter (#2614)
261ddc8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@apbose apbose Awaiting requested review from apbose

@gs-olive gs-olive Awaiting requested review from gs-olive

Assignees

@zewenli98 zewenli98

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aten.adaptive_avg_pool1d
4 participants
@zewenli98 @narendasan @gs-olive @facebook-github-bot