Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[super ugly maybe working code] use shim.h instead of Tensor #1548

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Jan 10, 2025

I KNOW THIS DOES NOT BUILD -- this should build now!

this is a poc change to see what making custom ops use aoti shim.h would look like

Copy link

pytorch-bot bot commented Jan 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1548

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit e1c39be with merge base 1beb6d0 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 10, 2025
@janeyx99 janeyx99 added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jan 16, 2025
@janeyx99 janeyx99 changed the title [super ugly not working code] use shim.h instead of Tensor [super ugly maybe working code] use shim.h instead of Tensor Jan 16, 2025
@@ -15,18 +19,18 @@ constexpr __host__ __device__ auto divUp(U a, V b) -> decltype(a + b) {
}
constexpr int32_t kWarpSize = 32;

//Simple data structure to represent 4 pairs of bfloat16s, used for vectorized dequantization
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UGH IGNORE the random VSCode formats--Idk how autoformat is turned on in this repo for me + will figure it out later, skip this line til 170!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants