Remove temp build files from torchao #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Removes temp build artifacts from experimental. Now the kernels are built and loaded with `USE_CPP=1 pip install .` from ao. Reviewed By: jerryzh168 Differential Revision: D67807207
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1551
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 31e78fb with merge base 6d6aa01 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67807207 |
jerryzh168
reviewed
Jan 11, 2025
| "Unable to load experimental torchao kernels. Performance will be slow." | ||
| ) | ||
| print( | ||
| "To install the kernels, run `USE_CPP=1 pip install .` from ao on a machine with an ARM CPU" |
There was a problem hiding this comment.
is this included in the default build as well? i.e. does installing torchao nightly include this?
There was a problem hiding this comment.
I quickly glanced and it does not look like the default nightly build for M1 mac defines USE_CPP=1, although adding it should be pretty simple.
jerryzh168
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Removes temp build artifacts from experimental. Now the kernels are built and loaded with
USE_CPP=1 pip install .from ao.Reviewed By: jerryzh168
Differential Revision: D67807207