Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module swap -> tensor subclass migration tutorial #1596

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

andrewor14
Copy link
Contributor

@andrewor14 andrewor14 commented Jan 22, 2025

Adds a migration tutorial from module swap to tensor subclass for expressing basic quantization. This is a simplified version of the existing subclass tutorials in torchao, removing layers of indirection like Layout and TensorImpl for ease of understanding. This commit also removes overlapping content from the existing contributor guide.

Work was done with @bdhirsh.

Preview the changes here: https://docs-preview.pytorch.org/pytorch/ao/1596/index.html

Copy link

pytorch-bot bot commented Jan 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1596

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 3 Pending, 1 Unrelated Failure

As of commit 4321d25 with merge base 4e4f4df (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2025
@andrewor14 andrewor14 marked this pull request as draft January 22, 2025 18:24
@andrewor14 andrewor14 force-pushed the subclass-tutorial branch 4 times, most recently from 564c52c to 21d8be3 Compare January 23, 2025 22:03
@andrewor14 andrewor14 changed the title [draft] Subclass tutorial coming soon Add module swap -> tensor subclass migration tutorial Jan 23, 2025
@andrewor14 andrewor14 added the topic: documentation Use this tag if this PR adds or improves documentation label Jan 23, 2025
@andrewor14 andrewor14 force-pushed the subclass-tutorial branch 6 times, most recently from d84a2d3 to b37ae96 Compare January 24, 2025 18:56
@andrewor14 andrewor14 force-pushed the subclass-tutorial branch 2 times, most recently from 39f2ece to 8499554 Compare January 24, 2025 19:46
@andrewor14 andrewor14 marked this pull request as ready for review January 24, 2025 19:46
@andrewor14 andrewor14 force-pushed the subclass-tutorial branch 2 times, most recently from 9a96ff5 to 3591008 Compare January 24, 2025 19:49
Adds a migration tutorial from module swap to tensor subclass for
expressing basic quantization. This is a simplified version of
the existing subclass tutorials in torchao, removing layers of
indirection like Layout and TensorImpl for ease of understanding.
This commit also removes overlapping content from the existing
contributor guide.

Work was done with @bdhirsh.
@andrewor14
Copy link
Contributor Author

Test failure is not related (H100 fp8 test), merging!

@andrewor14 andrewor14 merged commit 860da26 into main Jan 24, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: documentation Use this tag if this PR adds or improves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants