Move fpx to tensor subclass #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1603
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 4 PendingAs of commit 77167eb with merge base 0fae693 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jainapurva
added
topic: not user facing
| @@ -456,6 +462,53 @@ class FloatxTensorCoreLayout(Layout): | |||
| mbits: int | |||
|
|
|||
|
|
|||
| class FloatxTensor(AffineQuantizedTensor): | |||
| """ | |||
| Floatx quantized tensor subclass which inherits AffineQuantizedTensor class. | |||
There was a problem hiding this comment.
It might be helpful for new users/developers to add a short sentence to the docstring explaining the difference between floatx and float8.
jainapurva
force-pushed
the
floatx_subclass
branch
from
55dee0e to
9213cf5
Compare
jainapurva
force-pushed
the
floatx_subclass
branch
from
9fc0f48 to
249987f
Compare
jainapurva
added a commit
that referenced
this pull request
Jan 24, 2025
This reverts commit 70be245.
jainapurva
added a commit
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a new FpxTensor subclass, for fpx (float1-float7) quantizations.
Motivation: Fpx, has it's own implementation of choose_qparams_and_quantize_affine_fpx, quantization and dequantization for floatx quantization, hence a new tensor-subclass improves the code-quality. It reduces re-directions in AQT, and improves readability.
Future goals: Remove the AQT abstraction and make it independent tensor-subclass
Test Plan : Green CI