Update cost function, use qLogEI in discrete MFKG tutorial #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cost function has pretty high fixed cost, whcih isn't the best to illustrate the algorithm (see pytorch#2523 (reply in thread) for discussion). Also updates to use `qLogEI` instead of `qEI` to get rid of the deprecation warning.
facebook-github-bot
added
the
CLA Signed
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2711 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 202 202
Lines 18602 18602
=======================================
Hits 18600 18600
Misses 2 2 ☔ View full report in Codecov by Sentry. |
saitcakmak
approved these changes
Jan 29, 2025
|
Do we need the comparison to LogEI in the notebook? We're not even plotting the comparison |
|
I think the comparison is still useful, you can see that you get a competitive suggestion for less budget even with one eval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cost function has pretty high fixed cost, whcih isn't the best to illustrate the algorithm (see #2523 (reply in thread) for discussion).
Also updates to use
qLogEIinstead ofqEIto get rid of the deprecation warning.