[RFC] Use uv package manager in GHA
#2713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2713 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 202 202
Lines 18602 18602
=======================================
Hits 18600 18600
Misses 2 2 ☔ View full report in Codecov by Sentry. |
|
sure that sounds like a good change, let's update this across the board. |
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@saitcakmak merged this pull request in 4a595f2. |
saitcakmak
added a commit
to facebook/Ax
that referenced
this pull request
Feb 3, 2025
Summary: Replicates pytorch/botorch#2713 for Ax. `uv` is much faster than `pip`, which leads to a couple minutes of speed up in each workflow, which can add up to meaningful compute savings over many CI runs we do every day. Pull Request resolved: #3290 Test Plan: Successful CI run Compared to a previous CI run Before - 155 secs of setup time (until test & coverage step): https://github.com/facebook/Ax/actions/runs/13040634315/job/36381474759 After - 48 secs of setup time (until test & coverage step): https://github.com/facebook/Ax/actions/runs/13061685440/job/36445887187 Reviewed By: Balandat Differential Revision: D68919180 Pulled By: saitcakmak
saitcakmak
added a commit
to facebook/Ax
that referenced
this pull request
Feb 3, 2025
Summary: Replicates pytorch/botorch#2713 for Ax. `uv` is much faster than `pip`, which leads to a couple minutes of speed up in each workflow, which can add up to meaningful compute savings over many CI runs we do every day. Pull Request resolved: #3290 Test Plan: Successful CI run Compared to a previous CI run Before - 155 secs of setup time (until test & coverage step): https://github.com/facebook/Ax/actions/runs/13040634315/job/36381474759 After - 48 secs of setup time (until test & coverage step): https://github.com/facebook/Ax/actions/runs/13061685440/job/36445887187 Reviewed By: Balandat Differential Revision: D68919180 Pulled By: saitcakmak
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Feb 3, 2025
Summary: Replicates pytorch/botorch#2713 for Ax. `uv` is much faster than `pip`, which leads to a couple minutes of speed up in each workflow, which can add up to meaningful compute savings over many CI runs we do every day. Pull Request resolved: #3290 Test Plan: Successful CI run Compared to a previous CI run Before - 155 secs of setup time (until test & coverage step): https://github.com/facebook/Ax/actions/runs/13040634315/job/36381474759 After - 48 secs of setup time (until test & coverage step): https://github.com/facebook/Ax/actions/runs/13061685440/job/36445887187 Reviewed By: Balandat Differential Revision: D68919180 Pulled By: saitcakmak fbshipit-source-id: 3953ce5ff1aaae78587e56ab4046f70fee86cdf7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across
uvwhile debugging the scipy slowdowns and noticed how much faster it is than vanillapip. Usinguvsaves a couple minutes in installing dependencies, which can add up to meaningful compute savings over many CI runs we do every day. Should we update all workflows to useuv?This PR updates
reusable_tutorials.ymlas an example.Before, with
pip: https://github.com/pytorch/botorch/actions/runs/13058152281/job/36434279975After, with
uv pip: https://github.com/pytorch/botorch/actions/runs/13058212963/job/36434483617