Reland of "Python binding to set/get CUDA rng state offset" (#99565) #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Why? * To reduce the latency of hot path in pytorch/pytorch#97377 Concern - I had to add `set_offset` in all instances of `GeneratorImpl`. I don't know if there is a better way. ~~~~ import torch torch.cuda.manual_seed(123) print(torch.cuda.get_rng_state()) torch.cuda.set_rng_state_offset(40) print(torch.cuda.get_rng_state()) tensor([123, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], dtype=torch.uint8) tensor([123, 0, 0, 0, 0, 0, 0, 0, 40, 0, 0, 0, 0, 0, 0, 0], dtype=torch.uint8) ~~~~ Reland of pytorch/pytorch#98965 (cherry picked from commit 8214fe07e8a200e0fe9ca4264bb6fca985c4911e) X-link: pytorch/pytorch#99565 Reviewed By: anijain2305 Differential Revision: D45130271 Pulled By: malfet fbshipit-source-id: a31caebf1cecd6a6f9d4552d98a2b9a6eb7690e5
|
This pull request was exported from Phabricator. Differential Revision: D45130271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Why?
Concern - I had to add
set_offsetin all instances ofGeneratorImpl. I don't know if there is a better way.Reland of pytorch/pytorch#98965
(cherry picked from commit 8214fe07e8a200e0fe9ca4264bb6fca985c4911e)
X-link: pytorch/pytorch#99565
Reviewed By: anijain2305
Differential Revision: D45130271
Pulled By: malfet