Continue benchmark other models even if one fails to export #6186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6186
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 64054b2 with merge base 8957dc8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
huydhn
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
|
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
The failures on the PR is expected, as I use this to test that other models can continue as usual https://github.com/pytorch/executorch/actions/runs/11310814159 |
guangy10
approved these changes
Oct 14, 2024
Summary: Fixes [T204330024](https://www.internalfb.com/intern/tasks/?t=204330024) ### Testing https://github.com/pytorch/executorch/actions/runs/11310814159 Reviewed By: guangy10 Differential Revision: D64295995 Pulled By: huydhn
facebook-github-bot
force-pushed
the
handle-model-export-failures
branch
from
8392c93 to
64054b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64295995 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes T204330024
Testing
https://github.com/pytorch/executorch/actions/runs/11310814159