Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc to include Benchmark Dashboard #6202

Closed
wants to merge 1 commit into from
Closed

Update doc to include Benchmark Dashboard #6202

wants to merge 1 commit into from

Conversation

guangy10
Copy link
Contributor

@guangy10 guangy10 commented Oct 14, 2024 •
edited
Loading

  • Linked to the dashboard
  • Removed static table
  • Updated supported backends to include MPS

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 14, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6202

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 12e903a with merge base aa852cc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 14, 2024
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 force-pushed the doc_link_to_benchmark_dashboard branch from e72b5d3 to a8a8c55 Compare October 14, 2024 22:09
@guangy10
Copy link
Contributor Author

Updated linter rule match pattern to exclude "ExecuTorch" within URLs

@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 force-pushed the doc_link_to_benchmark_dashboard branch from a8a8c55 to 67be5ba Compare October 14, 2024 23:23
@guangy10 guangy10 force-pushed the doc_link_to_benchmark_dashboard branch from 67be5ba to 12e903a Compare October 14, 2024 23:25
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10
Copy link
Contributor Author

@kirklandsign maybe we should increase the iterations to offset the data fluctuation we observed on the dashboard. Checked with @shoumikhin , the iOS side is running 5 iterations atm. I think we should bump up both, maybe to 50?

@facebook-github-bot
Copy link
Contributor

@guangy10 merged this pull request in 09367a8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbort dbort dbort left review comments

@kirklandsign kirklandsign kirklandsign approved these changes

@huydhn huydhn huydhn approved these changes

@mergennachin mergennachin Awaiting requested review from mergennachin

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guangy10 @facebook-github-bot @huydhn @dbort @kirklandsign