Support Half/BFloat16 in op_allclose #7766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We incorrectly required these types to be bitwise-identical rather than close. (I had to develop this internally because the op_allclose_test doesn't run in OSS.) Differential Revision: [D68366831](https://our.internmc.facebook.com/intern/diff/D68366831/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7766
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit c620875 with merge base 2db2bd2 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Jan 18, 2025
We incorrectly required these types to be bitwise-identical rather than close. (I had to develop this internally because the op_allclose_test doesn't run in OSS.) Differential Revision: [D68366831](https://our.internmc.facebook.com/intern/diff/D68366831/) ghstack-source-id: 262016378 Pull Request resolved: #7766
|
This pull request was exported from Phabricator. Differential Revision: D68366831 |
swolchok
added
the
release notes: ops & kernels
swolchok
requested review from
shoumikhin and
mcr229
and removed request for
SS-JIA
|
This pull request was exported from Phabricator. Differential Revision: D68366831 |
We incorrectly required these types to be bitwise-identical rather than close. Partial fix for #7748. (I had to develop this internally because the op_allclose_test doesn't run in OSS.) Differential Revision: [D68366831](https://our.internmc.facebook.com/intern/diff/D68366831/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jan 22, 2025
Pull Request resolved: #7766 We incorrectly required these types to be bitwise-identical rather than close. (I had to develop this internally because the op_allclose_test doesn't run in OSS.) Differential Revision: [D68366831](https://our.internmc.facebook.com/intern/diff/D68366831/) ghstack-source-id: 262600586
|
This pull request was exported from Phabricator. Differential Revision: D68366831 |
manuelcandales
approved these changes
Jan 23, 2025
facebook-github-bot
merged commit 99489fe
into
gh/swolchok/149/base
44 of 47 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Jan 27, 2025
Pull Request resolved: #7766 We incorrectly required these types to be bitwise-identical rather than close. (I had to develop this internally because the op_allclose_test doesn't run in OSS.) Differential Revision: [D68366831](https://our.internmc.facebook.com/intern/diff/D68366831/) ghstack-source-id: 262600586 Co-authored-by: Scott Wolchok <[email protected]>
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Pull Request resolved: #7766 We incorrectly required these types to be bitwise-identical rather than close. (I had to develop this internally because the op_allclose_test doesn't run in OSS.) Differential Revision: [D68366831](https://our.internmc.facebook.com/intern/diff/D68366831/) ghstack-source-id: 262600586 Co-authored-by: Scott Wolchok <[email protected]>
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Pull Request resolved: pytorch#7766 We incorrectly required these types to be bitwise-identical rather than close. (I had to develop this internally because the op_allclose_test doesn't run in OSS.) Differential Revision: [D68366831](https://our.internmc.facebook.com/intern/diff/D68366831/) ghstack-source-id: 262600586 Co-authored-by: Scott Wolchok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
We incorrectly required these types to be bitwise-identical rather than close. Partial fix for #7748.
(I had to develop this internally because the op_allclose_test doesn't run in OSS.)
Differential Revision: D68366831