Conditionally support expand_copy in XNNPACK delegate #7960
+837
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Expand is sometimes used to to express an unsqueeze operation (inserting singleton dims) - one motivating example is in MobileBERT (link). This PR adds a pass to XNNPACK to conditionally transform expand_copy into view_copy, as long as the expand is used solely to add singleton dimensions. It also updates the partitioner with the appropriate constraint.
Note that this PR is stacked on top of #7959, as it relies on these changes (delegation of view_copy).
Test plan
Added test coverage in
backends/xnnpack/test/ops/test_expand.py
andbackends/xnnpack/test/passes/test_expand_to_view_pass.py
. These cover end-to-end delegation and pass-specific logic.