Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOCOMMIT: log peak mem usage and swapouts to debug test-llava-runner #8192

Closed
wants to merge 2 commits into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Feb 4, 2025

Attempting to test my theory that the timestamp gaps in #8180 are caused by swapping.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 4, 2025

swolchok added a commit that referenced this pull request Feb 4, 2025
Attempting to test my theory that the timestamp gaps in #8180 are caused by swapping.

ghstack-source-id: e2aa5b03d999423756923b0619e52b29a0dfbe74
ghstack-comment-id: 2634969596
Pull Request resolved: #8192
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 4, 2025
Copy link

pytorch-bot bot commented Feb 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8192

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures

As of commit f3ec03c with merge base a3455d9 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

github-actions bot commented Feb 4, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@swolchok swolchok marked this pull request as draft February 4, 2025 20:27
@swolchok
Copy link
Contributor Author

swolchok commented Feb 4, 2025

initial run inconclusive (did not demonstrate swapping, but can't rule it out yet); there was a timestamp gap in the middle of the added log messages, but they were demonstrably all generated with a timestamp before the end of the gap. Adding another log message at what seems to be a better place and retrying.

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 4, 2025
Attempting to test my theory that the timestamp gaps in #8180 are caused by swapping.

ghstack-source-id: 45e7e64de3b231a87a9a9e97212d0c66456aec31
ghstack-comment-id: 2634969596
Pull Request resolved: #8192
@swolchok
Copy link
Contributor Author

swolchok commented Feb 5, 2025

OK I think I'm satisfied that we're not swapping. https://github.com/pytorch/executorch/actions/runs/13144066347/job/36677928636?pr=8192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants