[ET-VK][int4] patch 4-bit linear op for ensuring w-packed in/out #8225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the partitioner is using channels-packed setting for activations, then the checks will throw. Remove the checks and conditionally re-pack the input/output tensors if they are not width-packed. Differential Revision: [D68813946](https://our.internmc.facebook.com/intern/diff/D68813946/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8225
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit fa0b991 with merge base 7805229 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68813946 |
nathanaelsee
added
the
release notes: vulkan
SS-JIA
approved these changes
Feb 5, 2025
…in/out" If the partitioner is using channels-packed setting for activations, then the checks will throw. Remove the checks and conditionally re-pack the input/output tensors if they are not width-packed. Differential Revision: [D68813946](https://our.internmc.facebook.com/intern/diff/D68813946/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68813946 |
…in/out" If the partitioner is using channels-packed setting for activations, then the checks will throw. Remove the checks and conditionally re-pack the input/output tensors if they are not width-packed. Differential Revision: [D68813946](https://our.internmc.facebook.com/intern/diff/D68813946/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68813946 |
…in/out" If the partitioner is using channels-packed setting for activations, then the checks will throw. Remove the checks and conditionally re-pack the input/output tensors if they are not width-packed. Differential Revision: [D68813946](https://our.internmc.facebook.com/intern/diff/D68813946/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68813946 |
facebook-github-bot
merged commit 6022854
into
gh/nathanaelsee/2/base
45 of 47 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Feb 6, 2025
Pull Request resolved: #8225 If the partitioner is using channels-packed setting for activations, then the checks will throw. Remove the checks and conditionally re-pack the input/output tensors if they are not width-packed. ghstack-source-id: 264952605 @exported-using-ghexport Differential Revision: [D68813946](https://our.internmc.facebook.com/intern/diff/D68813946/) --------- Co-authored-by: Nathanael See <[email protected]>
This was referenced Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
If the partitioner is using channels-packed setting for activations, then the checks will throw.
Remove the checks and conditionally re-pack the input/output tensors if they are not width-packed.
Differential Revision: D68813946