Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install mkl for PyTorch and libjpeg/libpng for TorchVision #8248

Merged
merged 15 commits into from
Feb 10, 2025

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Feb 6, 2025

Fixes #8180

I should have caught this earlier that we didn't have mkl here, so PyTorch performance on x86 CPU suffered.

Copy link

pytorch-bot bot commented Feb 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8248

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c5dcd2d with merge base b1d76c9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 6, 2025
@huydhn huydhn changed the title Install libjpeg and libpng for TorchVision Install mkl for PyTorch and libjpeg/libpng for TorchVision Feb 6, 2025
Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you've got conda library problems but this is clearly a PR I should accept, contingent on you seeing llava-runner job improve

@huydhn
Copy link
Contributor Author

huydhn commented Feb 7, 2025

looks like you've got conda library problems but this is clearly an accept contingent on you seeing llava-runner job improve

Let me look more into that conda issue. This is rather unexpected, I have done a rebase, so the failure is legit.

@huydhn
Copy link
Contributor Author

huydhn commented Feb 9, 2025

looks like you've got conda library problems but this is clearly a PR I should accept, contingent on you seeing llava-runner job improve

Just FYI, the linking error is from this hack https://github.com/pytorch/executorch/blob/main/.ci/docker/common/install_conda.sh#L46-L58

@huydhn huydhn marked this pull request as ready for review February 9, 2025 19:59
@huydhn
Copy link
Contributor Author

huydhn commented Feb 10, 2025

@huydhn huydhn merged commit 524ec78 into main Feb 10, 2025
52 checks passed
@huydhn huydhn deleted the fix-llava-runner-timeout branch February 10, 2025 02:27
@swolchok
Copy link
Contributor

eval_llama-mmlu seems to have gone from 1.9h to under 9 minutes: https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=mmlu&mergeLF=true

swolchok added a commit that referenced this pull request Feb 10, 2025
#8173 raised these timeouts. Now that #8248 has landed to fix #8180, we should be able to lower them again. (I'm sending this early so I don't forget; double-check llava-runner running time)

ghstack-source-id: cb4c1691907b8bb46a504a2d8cbc00d12b1ef4a4
ghstack-comment-id: 2648474106
Pull Request resolved: #8339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI timeout (test-llava-runner-linux) since #7922
3 participants