Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension/llm/custom_ops/spinquant/test to CMake #8345

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Feb 10, 2025

Need to run it to make sure build changes in this directory aren't breaking things.

Test Plan: added EXPECT_TRUE(false) to fast_hadamard_transform_test.cpp, saw failure in test/run_oss_cpp_tests.sh

Copy link

pytorch-bot bot commented Feb 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8345

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit a826c40 with merge base e74b141 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
@swolchok swolchok force-pushed the gh/swolchok/242/head branch from 773ff37 to d4aaa36 Compare February 12, 2025 21:41
@swolchok
Copy link
Contributor Author

this isn't correct yet; test doesn't run when I run test/run_oss_cpp_tests.sh and I'm not sure why yet.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants