Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove python 3.7 support #314

Open
wants to merge 7 commits into
base: gh/PaliC/101/base
Choose a base branch
from
Open

remove python 3.7 support #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
23b2223
remove python 3.7 support
PaliC Apr 7, 2023
9f80e2a
Update on "remove python 3.7 support"
PaliC Apr 10, 2023
b2494a2
Update on "remove python 3.7 support"
PaliC Apr 10, 2023
6c3071f
Update on "remove python 3.7 support"
PaliC Apr 10, 2023
e7fb183
Update on "remove python 3.7 support"
PaliC Apr 10, 2023
ce35f8a
Update on "remove python 3.7 support"
PaliC Apr 10, 2023
8123e13
Update on "remove python 3.7 support"
PaliC Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 13 additions & 25 deletions .github/workflows/build_test_release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,24 +40,15 @@ jobs:
echo "::endgroup::"

echo "::group::Setup virtual environment"
if [[ ${{ inputs.python3-minor-version }} -gt 7 ]];
then
conda install -y python=${python_version} mkl mkl-include conda-build pyyaml numpy ipython
conda install -y -c conda-forge libpython-static=${python_version}
conda install -y pytorch torchvision torchaudio cpuonly -c pytorch
conda clean -ya;
else
conda deactivate
pip install virtualenv
git clone https://github.com/pyenv/pyenv.git ~/.pyenv
export CFLAGS="-fPIC -g"
~/.pyenv/bin/pyenv install --force ${python_version}
virtualenv -p ~/.pyenv/versions/$(~/.pyenv/bin/pyenv latest ${python_version})/bin/python3 ~/venvs/multipy
source ~/venvs/multipy/bin/activate
pip install \
torch torchvision torchaudio \
--extra-index-url https://download.pytorch.org/whl/cpu;
fi
echo "conda install -y python=${python_version}"
conda install -y python=${python_version}
echo "conda install -y -c conda-forge libpython-static=${python_version}"
conda install -y -c conda-forge libpython-static=${python_version}
echo "conda install -y mkl-include pyyaml numpy ipython"
conda install -y mkl mkl-include pyyaml numpy ipython
echo "conda install -y pytorch torchaudio cpuonly -c pytorch"
conda install -y pytorch torchaudio cpuonly -c pytorch
conda clean -ya;
echo "::endgroup::"

echo "::group::Install"
Expand Down Expand Up @@ -94,13 +85,10 @@ jobs:
./multipy/runtime/build/deploy_benchmark 2 none jit multipy/runtime/example/generated/resnet
echo "::endgroup::"

if [[ ${{ inputs.python3-minor-version }} -gt 7 ]];
then
echo "::group::Compat test"
pip install -r compat-requirements.txt
multipy/runtime/build/interactive_embedded_interpreter --pyscript multipy/runtime/test_compat.py
echo "::endgroup::";
fi
echo "::group::Compat test"
pip install -r compat-requirements.txt
multipy/runtime/build/interactive_embedded_interpreter --pyscript multipy/runtime/test_compat.py
echo "::endgroup::";

echo "::group::Test GPU"
# Separating GPU tests due to issues with py37 and py38: https://github.com/pytorch/multipy/issues/239
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/install_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
installtest:
strategy:
matrix:
python3-minor-version: [7,8,9,10]
python3-minor-version: [8,9,10]
platform: [ubuntu-18.04]
fail-fast: false
runs-on: ${{ matrix.platform }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/runtime_nightly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
build-test-release:
strategy:
matrix:
python3-minor-version: [7,8,9,10]
python3-minor-version: [8,9,10]
platform: [linux.4xlarge.nvidia.gpu]
fail-fast: false
uses: ./.github/workflows/build_test_release.yaml
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/runtime_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
unittest:
strategy:
matrix:
python3-minor-version: [7,8,9,10]
python3-minor-version: [8,9,10]
platform: [linux.4xlarge.nvidia.gpu]
fail-fast: false
uses: ./.github/workflows/build_test_release.yaml
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_docker_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
unittest:
strategy:
matrix:
python3-minor-version: [7,8,9,10]
python3-minor-version: [8,9,10]
platform: [linux.4xlarge.nvidia.gpu]
fail-fast: false
runs-on: ${{ matrix.platform }}
Expand Down
4 changes: 2 additions & 2 deletions multipy/runtime/test_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ def test_torchvision(self):
def test_torchaudio(self):
import torchaudio # noqa: F401

def test_pytorch3d(self):
import pytorch3d # noqa: F401
# def test_pytorch3d(self):
# import pytorch3d # noqa: F401

def test_hf_tokenizers(self):
import tokenizers # noqa: F401
Expand Down