Remove mentions of 2.4 in docs and error messages #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
commented
Nov 12, 2024
| 2. The PyTorch version ({torch.__version__}) is not compatible with | ||
| this version of TorchCodec. Refer to the version compatibility | ||
| table: | ||
| https://github.com/pytorch/torchcodec?tab=readme-ov-file#installing-torchcodec. |
There was a problem hiding this comment.
Sadly it's impossible to tell users which version of torchcodec they're using, because the torchcodec module isn't fully initialized at this point. There's also no point telling them "you can figure it out by doing python -c 'import torchcodec; print(torchcodec.__version__)'" because it is precisely the import torchcodec` part that is triggering the RuntimeError of the above message.
NicolasHug
commented
Nov 12, 2024
| - [Ship wheels for MacOS](https://github.com/pytorch/torchcodec/issues/111), so | ||
| that MacOS users can `pip install torchcodec`. For now this is only supported | ||
| on Linux, but MacOS users can [build from source](./CONTRIBUTING.md). | ||
| - [GPU decoding](https://github.com/pytorch/torchcodec/pull/58) |
scotts
approved these changes
Nov 12, 2024
Comment on lines
+124
to
+128
| | `torchcodec` | `torch` | Python | | ||
| | ------------------ | ------------------ | ------------------- | | ||
| | `main` / `nightly` | `main` / `nightly` | `>=3.9`, `<=3.12` | | ||
| | not yet supported | `2.5` | `>=3.9`, `<=3.12` | | ||
| | `0.0.3` | `2.4` | `>=3.8`, `<=3.12` | |
There was a problem hiding this comment.
Do we want to have a torchcodec with cuda column here too?
There was a problem hiding this comment.
Not sure if I understand correctly. The CPU and CUDA version of torchcodec should have the same expected pytorch version?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #235
This PR also: