Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _test_pg helper #45

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Add _test_pg helper #45

merged 2 commits into from
Dec 18, 2024

Conversation

H-Huang
Copy link
Member

@H-Huang H-Huang commented Dec 17, 2024 •
edited
Loading

Fix #32. Add a helper method _test_pg that runs multiple collectives.

Potential follow ups:

  • Update ErrorSwallowingProcessGroupWrapper and ManangedProcessGroup to support the other collectives
  • additional consolidation of the tests. Can parametrize them based off the process group class?
  • validate output values (maybe not necessary since this validation is done at pytorch collective level and these PGs are all wrapping those)
  • move tests to a separate test folder

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 17, 2024
@H-Huang H-Huang marked this pull request as ready for review December 18, 2024 00:11
@H-Huang H-Huang requested a review from d4l3k December 18, 2024 12:56
d4l3k
d4l3k approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CONTRIBUTING.md Show resolved Hide resolved
@H-Huang H-Huang merged commit 49d2aec into pytorch:main Dec 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4l3k d4l3k d4l3k approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tests] add generic size/type test for all ProcessGroups
3 participants
@H-Huang @d4l3k @facebook-github-bot