-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate new released Falcon3 Family base models #2171
base: nightly
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2171
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @abdalgader-a! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
This looks pretty great and we'd love to have the new Falcon models! Could you rebase this on torchtune:main instead of nightly? |
Hey @abdalgader-a - are you still interested in working on this PR? |
Hi @joecummings -- thanks for your interest on Falcon models! We are still working on the process of signing the CLA. Once done, I'll finalize this PR. Thanks! |
Hi @abdalgader-a just want to check in on this PR. How is the CLA process going? Please let me know if there's anything you need from us. |
Hi @ebsmothers -- didn't get the approval from our legal team and might take sometime due to some misalignment with Falcon licensee. So, I think we can catch the next release of torchtune. |
Context
What is the purpose of this PR?