-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement step based checkpointing #2384
Draft
joecummings
wants to merge
15
commits into
pytorch:main
Choose a base branch
from
joecummings:impl-step-based-ckpt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+504
−222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2384
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 5 Cancelled JobsAs of commit 4d11a48 with merge base 2128559 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
20f2acf
to
46f7c67
Compare
|
…l_step_resume fix: Global step resume from recipe_state
…d get resume working w/ StatefulDataLoader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
Closes #2105. This is a widely requested feature that allows users to have greater control over checkpointing frequency in torchtune.
TODO: Add commentary on design decisions. Acknowledge spaghetti code. Beg forgiveness.
Changelog
FullModelHFCheckpointer
to accept a step parameter when saving a checkpoint. Use that step to designate the checkpoint folder name. Keepepoch_{}
as a fall-back for BC.prune_surplus_checkpoints
that removes extra checkpoints in order to free up space for the user. This is controlled by thekeep_n_last_checkpoints
.get_all_checkpoints_in_dir
that scans a directory (meant for the output_dir) and returns all checkpoint directories.full_finetune_single_device.py
recipe to utilize step-based checkpointing.Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install
)pytest tests
pytest tests -m integration_test
Ran single device recipe w/ step-based checkpointing
Evidence of succesful run
Evidence of correct number of checkpoints being saved
Evidence of correct resuming from ckpt
![Screenshot 2025-02-14 at 11 55 23 AM](https://private-user-images.githubusercontent.com/20175092/413401470-1a951b77-e513-420f-9a29-727228859315.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MDcyMzksIm5iZiI6MTczOTYwNjkzOSwicGF0aCI6Ii8yMDE3NTA5Mi80MTM0MDE0NzAtMWE5NTFiNzctZTUxMy00MjBmLTlhMjktNzI3MjI4ODU5MzE1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA4MDg1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI1OTU5OTZlOTZlNWIzM2FmMjMxMTQwM2M5MDQ3NWJiNzUxNzBiYTQ4YmRlNDIxN2I4ZjI0ZTM4YzRlNDJhOWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.HbSFQqcypY_87x6zxflrCes16qciRH9t9ZAH34Yug4k)
UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example