Skip to content
This repository has been archived by the owner on Nov 11, 2019. It is now read-only.

Use pkgutil to load video_reqs.json #55

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions steve/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import datetime
import json
import os
import pkgutil
import string
import sys
import textwrap
Expand Down Expand Up @@ -301,10 +302,8 @@ def generate_filename(text):


def get_video_requirements():
fn = os.path.join(os.path.dirname(__file__), 'video_reqs.json')
fp = open(fn)
data = json.load(fp)
fp.close()
binary_json_string = pkgutil.get_data('steve', 'video_reqs.json')
data = json.loads(binary_json_string.decode('UTF-8'))
return data


Expand Down
8 changes: 8 additions & 0 deletions tests/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

from steve.util import (
get_video_id,
get_video_requirements,
html_to_markdown,
is_youtube,
SteveException,
Expand Down Expand Up @@ -162,3 +163,10 @@ def test_get_video_id():
for url in data:
with pytest.raises(SteveException):
get_video_id(url)


def test_get_video_requirements():
# Test fetching video_reqs.json from package
data = get_video_requirements()
assert type(data) == list
assert len(data) > 0