Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PR #1013

Merged
merged 16 commits into from
Feb 12, 2025
Merged

Release PR #1013

merged 16 commits into from
Feb 12, 2025

Conversation

KochTobi
Copy link
Member

@KochTobi KochTobi commented Feb 11, 2025

What's Changed

New Features 🚀

Bugfixes 🪲

Documentation & CI 🪂

Full Changelog: 1.7.2...1.8.0

sven1103 and others added 15 commits January 7, 2025 10:27

A stepper dialog (also known as wizard), contains at least two steps that are displayed consecutively to the user and ask them for input. They are usually applied when the user input is more complex, is conditionally chained, or can be separated contextually into logical steps.

This contribution introduces a stepper dialog component, that is easy to build and extend, and simplifies the stepper dialog creation.
…ation (#961)

Removes the dummy contact selection for collaborators within the project creation dialog for admins.
…ate (#960)

Addresses #951 by only showing the helperbox in the header row and first row of each template.
Co-authored-by: Tobias Koch <[email protected]>
Provide the comments for singular samples within the measurement overview, while providing the possiblity to open the information dialog for pooled samples
---------

Co-authored-by: Sven F. <[email protected]>
…#974)

Enables more complex toasts by allowing to add components to the toast.

Provides a method to create toasts for pending tasks.
Displays pending registration toasts, finished toasts and toasts for update + deletion of measurement entities.
Toasts are yummie.

---------

Co-authored-by: Steffengreiner <[email protected]>
Adds the technical replicate information as column to the grid showing proteomics measurements.

Co-authored-by: KochTobi <[email protected]>
# Conflicts:
#	user-interface/src/main/java/life/qbic/datamanager/templates/measurement/NGSMeasurementEditTemplate.java
#	user-interface/src/main/java/life/qbic/datamanager/templates/measurement/NGSMeasurementRegisterTemplate.java
#	user-interface/src/main/java/life/qbic/datamanager/templates/measurement/ProteomicsMeasurementEditTemplate.java
#	user-interface/src/main/java/life/qbic/datamanager/templates/measurement/ProteomicsMeasurementRegisterTemplate.java
#	user-interface/src/main/java/life/qbic/datamanager/templates/sample/SampleBatchRegistrationTemplate.java
#	user-interface/src/main/java/life/qbic/datamanager/templates/sample/SampleBatchUpdateTemplate.java
Closes all dialogs upon navigation change, except the AppDialog.

For the AppDialog, the immediate close will be only executed, if there are no changes.

---------

Co-authored-by: Steffengreiner <[email protected]>
* add todo to open PR

* add mermaid plot

* change to identifier

* add sequence diagrams

* update sql scripts

* Pass schema validation

* Fix order of statements

* do not allow null values for measurement counts

* refine diagram

* update sql so it only creates missing tables

* minimal example

* add javadoc

* wip

* add confounding variables to templates

* move the `@Transactional` aspect to the implementing class

> The Spring team recommends that you annotate methods of concrete classes with the @transactional annotation, rather than relying on annotated methods in interfaces, even if the latter does work for interface-based and target-class proxies as of 5.0.
https://docs.spring.io/spring-framework/reference/data-access/transaction/declarative/annotations.html

* wip

* wip

* wip

* Fix file size formatting

* Fix connection testing for openbis

* Add equals and hash code to Sample.java object

* implement the update case for confounding variables

* Implement sample/batch deletion

* extract methods for measurement and sample creation in openbis

* Fix merge breaks

* fix test

* update demo with detail box and cards

* static import of Objects.requireNonNull

* Add javadoc to HasBoundField.java

* Extract StringBean

* Add color and cursor classes

* replace random by cursor

* add missing flex-align-items-baseline

* Add ConfoundingVariablesUserInput

* Add info text and adjust gap

* Add tab for confounding variables

* update dev bundle

* show existing confounding variables

* add new confounding variables

* Implement editing of confounding variables

* Throw exception for duplicate columns

* Prevent creation and rename of duplicate confounding variable

* Prevent duplicate naming and accidental deletion

* prettify frontend

* Fix groups not being loaded

* remove file

* Address sonar cloud analysis of SampleRepositoryImpl.java

* address further sonarcloud issues

* Rename method

Co-authored-by: Sven F. <[email protected]>

* remove Propagation.REQUIRES_NEW

I don't think we need a new transaction when creating samples
Co-authored-by: Sven F. <[email protected]>

* Replace Map#foreach with Collectors#toMap

Co-authored-by: Sven F. <[email protected]>

* Ask before deleting confounding variables

Co-authored-by: Sven F. <[email protected]>

---------

Co-authored-by: KochTobi <[email protected]>
Co-authored-by: Sven F. <[email protected]>
* Fix confounding variable service crashing

The confounding variable service crashed during sample registration if no confounding variables exist in the experiment. This commit checks for an empty set of confounding variables and returns directly

* Log exception

---------

Co-authored-by: KochTobi <[email protected]>
* replace measurement templates

* Move sample templates

* Remove templates and correct autosizing of columns

* Switch to new xlsx generation for sample metadata download

* remove duplicate class

* File name by experiment name instead of project code

* Adapt to confounding variables

* Move ROCrate export

* remove unused field

* Use downloadComponent

* Move classes

* Remove FileDownloadStreamProvider.java

* Reduce complexity

* Centralize file name formatting

* Adapt filename for proteomics measurements

* Change file name pattern

---------

Co-authored-by: KochTobi <[email protected]>
The openbis api only specifies a List but expects a mutable List.

Co-authored-by: KochTobi <[email protected]>
* Provide pooling name in measurement overview

* Open failure notification toast on registration failure

* Remove old dependency

* only show pool name in sample column

---------

Co-authored-by: KochTobi <[email protected]>
Co-authored-by: Sven F. <[email protected]>
Co-authored-by: Sven Fillinger <[email protected]>
@KochTobi KochTobi requested a review from a team as a code owner February 11, 2025 13:13
* Fix issue with sample creation

For some reason the openbis server crashes the operation if the list of operations is unmodifiable. Switching to a modifiable ArrayList seems to solve the issue.

Co-authored-by: Sven F. <[email protected]>

* Provide DataManagerVault

* Add JDs

* Add readme

* Change test secret to doc secret

* Implement DisposableBean interface for vault

* Ignore local PKCS12 stores

* Refactor session handling

* Checkin work

* JDs

* Execute operations asyncronously to avoid deadlocks

* Apply JDs

* Fix readme

* Introduce retry for operations

* Add debug statement

* Switch back to Synchrounous execution

* Enhance logs

* Improve retry

* Put debug log to the start

* Move property descriptions

* Update README.md

Co-authored-by: Tobias Koch <[email protected]>

---------

Co-authored-by: KochTobi <[email protected]>
Co-authored-by: Sven F. <[email protected]>
Co-authored-by: Tobias Koch <[email protected]>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
4.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@sven1103 sven1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sven1103 sven1103 merged commit 7f21cac into main Feb 12, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants