-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indicate vertices order orientation in polygon part and ring geometries #9523
base: master
Are you sure you want to change the base?
Conversation
in polygon part and ring geometries fixes qgis#8658
and remove a fix me (refs qgis/QGIS#50447)
@lbartoletti May I request your review whether I summarized correctly the changes, please? Thanks. |
.. note:: **Order of vertices in polygon parts** | ||
|
||
Unlike the OGC standards, QGIS doesn't constrain vertices | ||
of the exterior boundary of a polygon feature to be ordered counterclockwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exact. However, you can "fix" the case using processing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main point I wanted to highlight in the note is the parts being oriented the same way. I thus added the "fix" tip in another paragraph.
A hole appears in the selected geometries. | ||
#. If no geometry is selected when the ring is drawn, | ||
then a hole is added to each of the polygons the ring is drawn over. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, you can add a note indicating that after AddRing
, the vertices of the inner rings are oriented in the opposite direction to the exterior ring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... Isn't this covered in the note just below?
Thus, you can find both directions in a layer. | ||
However, every parts of the same multipolygon feature | ||
will have their outer vertices ordered following the same direction. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can however use the :ref:`qgisforcerhr` algorithm to constrain features of a layer | |
to have vertices of their outer boundaries ordered in the clockwise direction. |
.. note:: **Order of vertices in polygon parts** | ||
|
||
Unlike the OGC standards, QGIS doesn't constrain vertices | ||
of the exterior boundary of a polygon feature to be ordered counterclockwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main point I wanted to highlight in the note is the parts being oriented the same way. I thus added the "fix" tip in another paragraph.
A hole appears in the selected geometries. | ||
#. If no geometry is selected when the ring is drawn, | ||
then a hole is added to each of the polygons the ring is drawn over. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... Isn't this covered in the note just below?
of the exterior boundary of a polygon feature to be ordered counterclockwise. | ||
Thus, you can find both directions in a layer. | ||
However, every rings of the same (multi)polygon feature | ||
will have their vertices ordered in the opposite direction to the outer boundary's. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can however use the :ref:`qgisforcerhr` algorithm to constrain features of a layer | |
to have vertices of their outer boundaries ordered in the clockwise direction, | |
and vertices of their interior rings ordered in the counter-clockwise direction. |
fixes #8658
Also update an old fix me and describe "add ring" how-to