Address review: rename method to be more API compliant

qgis · Oct 17, 2024 · 3fa61a0 · 3fa61a0
1 parent e696fae
commit 3fa61a0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/gui/vector/qgsdiagramproperties.cpp b/src/gui/vector/qgsdiagramproperties.cpp
@@ -878,7 +878,7 @@ std::unique_ptr< QgsDiagram > QgsDiagramProperties::createDiagramObject()
 std::unique_ptr<QgsDiagramSettings> QgsDiagramProperties::createDiagramSettings()
 {
   std::unique_ptr< QgsDiagramSettings > ds = std::make_unique< QgsDiagramSettings>();
-  ds->enabled = enabledDiagram();
+  ds->enabled = isDiagramEnabled();
   ds->font = mDiagramFontButton->currentFont();
   ds->opacity = mOpacityWidget->opacity();
 
@@ -1046,7 +1046,7 @@ void QgsDiagramProperties::apply()
   QgsSettings settings;
   if ( !dockMode() || !settings.value( QStringLiteral( "UI/autoApplyStyling" ), true ).toBool() )
   {
-    if ( enabledDiagram() && 0 == mDiagramAttributesTreeWidget->topLevelItemCount() )
+    if ( isDiagramEnabled() && 0 == mDiagramAttributesTreeWidget->topLevelItemCount() )
     {
       QMessageBox::warning( this, tr( "Diagrams: No attributes added." ),
                             tr( "You did not add any attributes to this diagram layer. Please specify the attributes to visualize on the diagrams or disable diagrams." ) );
@@ -1325,7 +1325,7 @@ void QgsDiagramProperties::setDiagramEnabled( bool enabled )
   mEnableDiagramCheckBox->setChecked( enabled );
 }
 
-bool QgsDiagramProperties::enabledDiagram() const
+bool QgsDiagramProperties::isDiagramEnabled() const
 {
   return mEnableDiagramCheckBox->isChecked();
 }
diff --git a/src/gui/vector/qgsdiagramproperties.h b/src/gui/vector/qgsdiagramproperties.h
@@ -209,15 +209,15 @@ class GUI_EXPORT QgsDiagramProperties : public QgsPanelWidget, private Ui::QgsDi
 
     /**
      * Sets widgets to reflect the \a enabled status of the diagram.
-     * @param enabled Whether the diagram is enabled or not.
+     * \param enabled Whether the diagram is enabled or not.
      */
     void setDiagramEnabled( const bool enabled );
 
     /**
      * Returns whether the current diagram should be enabled or not,
      * according to changes in the corresponding widgets.
      */
-    bool enabledDiagram() const;
+    bool isDiagramEnabled() const;
 
     friend class QgsStackedDiagramProperties;
     friend class QgsStackedDiagramPropertiesDialog;