-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Qt6 builds based on vcpkg #57414
Conversation
Nice work @m-kuhn ! Could you adapt the logic from https://github.com/qgis/QGIS/blob/master/.github/workflows/mingw64.yml#L97 to tag the artifact with the corresponding pr number and sha, and then update https://github.com/qgis/QGIS/blob/master/.github/workflows/build_artifact_comment.yml#L5 so that we get a PR comment with a direct link to download the qt6 artifacts? |
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist. |
I will get back to this asap |
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist. |
Using the windows executable from https://github.com/qgis/QGIS/actions/runs/9731000236 of qgis/QGIS#57414 The .lyr file was not "loaded" per se, but used and with the loaded layer then a new .lyr was exported.
Using the windows executable from https://github.com/qgis/QGIS/actions/runs/9731000236 of qgis/QGIS#57414 The .lyr file was not "loaded" per se, but used and with the loaded layer then a new .lyr was exported.
…rtualbox) Loaded QGIS 3.34.10 with Qt 5.15.13 (Windows), re-saved in QGIS c53d416c with Qt 6.7.0 (Windows, Virtualbox) Using the windows executable from https://github.com/qgis/QGIS/actions/runs/9731000236 of qgis/QGIS#57414 The .lyr file was not "loaded" per se, but used and with the loaded layer then a new .lyr was exported.
Description
Refs qgis/QGIS-Enhancement-Proposals#292
This adds windows builds with Qt6, based on vcpkg dependencies.
The features
WITH_BINDINGS
,WITH_3D
andWITH_GUI
are supported and appropriately enable or disable building the required dependencies. Feature dependencies for server, opencl and quick are prepared but not yet wired.Python support is consumed from https://github.com/open-vcpkg/python-registry/ . This is currently focused on shipping python dependencies that contain native code (dll's). Other dependencies can be installed using pip.
It is currently based on Qt 6.7.0.
Various Qt6 compatibility patches have been ported from #56980 and #56841 (QGIS code is now wchar / unicode aware for Qt6, external dependencies are patched to make them build).
TODO:
bin
More ideas:
X_VCPKG_APPLOCAL_DEPS_INSTALL
instead of blindly copying all .dll's, probably in a followup PR