VSI credentials followups #57868
Merged
VSI credentials followups #57868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and make API more useful for other use cases. The zip icon should not be used for cloud based vsi prefixes
Don't force a deep scan for sublayers when the caller has requested a fast scan and a vsi cloud uri is being scanned
Ensure credentials are respected in the provider source, so that layer source's don't drop this information
nyalldawson
commented
Jun 25, 2024
rouault
reviewed
Jun 25, 2024
nyalldawson
force-pushed
the
vsi_followups
branch
from
5732d7a to
9532b8e
Compare
|
@rouault does this look ok to you now? |
rouault
approved these changes
Jun 26, 2024
|
Thanks @rouault ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of follow up fixes and cleanups for #57826