Fix text wrapping stability for small text #58145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
commented
Jul 17, 2024
nyalldawson
force-pushed
the
scaling_factor
branch
from
3524a93 to
f02eed1
Compare
Adjust the QgsTextRenderer::calculateScaleFactorForFormat logic so that small text is scaled up to at least 50 pixels when calculating text metrics This avoids tiny differences in calculated text metrics for small text from affecting how text wrapping is calculated, which can otherwise result in words at the end of lines "bouncing" from line to line as layouts and maps are zoomed out
nyalldawson
force-pushed
the
scaling_factor
branch
from
180b5e3 to
f71c8ad
Compare
alexbruy
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the QgsTextRenderer::calculateScaleFactorForFormat logic so that small text is scaled up to at least 50 pixels when calculating text metrics
This avoids tiny differences in calculated text metrics for small text from affecting how text wrapping is calculated, which can otherwise result in words at the end of lines "bouncing" from line to line as layouts and maps are zoomed out
I realise the test mask updates here look scary! I've gone over the results one-by-one and carefully compared before and after rendering. There's no regressions here -- the differences are all sub-pixel changes in font antialiasing, with neither before nor after being significantly better or worse.