Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-3_38] Fix CRS flagged as invalid from standalone code #58565

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

qgis-bot
Copy link
Collaborator

@qgis-bot qgis-bot commented Sep 3, 2024

Backport #58556
Authored by: @nyalldawson

Correctly handle the situation where multiple
QgsCoordinateReferenceSystemRegistry objects are created. This can
happen when something tries to create a CRS before the
QgsApplication is properly constructed.

In this situation the std::once calls were incorrectly causing
the member cached objects to only be populated for the FIRST
registry created.

Move to static objects were possible, and use a local mutex
to protect other create-once, registry specific caches.

Fixes #55161
@github-actions github-actions bot added this to the 3.38.3 milestone Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 6dd5a84)

@nyalldawson nyalldawson merged commit c5a1ee8 into release-3_38 Sep 4, 2024
32 checks passed
@nyalldawson nyalldawson deleted the backport-58556-to-release-3_38 branch September 4, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants