[gui] Fix enable/disable diagrams (as well as subdiagrams of a stacked diagram) #59098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nyalldawson
reviewed
Oct 15, 2024
nyalldawson
approved these changes
Oct 16, 2024
gacarrillor
force-pushed
the
fix_enabled_diagram_setting
branch
from
70bca94 to
8c8dcfc
Compare
|
@gacarrillor can you rebase please? |
…gsDiagramProperties, so that's explicit whether the diagram is enabled or not as well as to toggle its enabled status
gacarrillor
force-pushed
the
fix_enabled_diagram_setting
branch
from
8c8dcfc to
2a61d31
Compare
@nyalldawson, rebasing, thanks for enforcing that in 440064a! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup #58568
New checkbox
Enable diagram:Current situation: The diagram's enabled setting cannot be set manually.
This PR: Adds a checkbox to read and set such a setting in the diagram properties dialog/panel.
Current situation: Subdiagrams can be disabled in the main panel of a stacked diagram. However, once a subdiagram is being edited, its disabled setting is no longer kept and there is no visual clue for the user about the enabled/disabled setting status.
This PR: Adds consistency to handling the enabled setting, i.e., changes in the status are visible and easily toggled via the new checkbox.
GUI consistency: I'm adhering here to similar widgets that have been employed in several QGIS modules before. For instance, for enabling/disabling labels in a
rule-based labelingor in theLayout map gridwidget.Screencast:
vokoscreenNG-2024-10-15_12-49-54.mp4