Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When excluding tests, only exclude exact matches. Fix some qt 6 tests. #59116

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

nyalldawson
Copy link
Collaborator

Otherwise eg an entry in the blocklist for PyQgsAnnotation will prevent the PyQgsAnnotationRectTextItem test from running

Otherwise eg an entry in the blocklist for PyQgsAnnotation will
prevent the PyQgsAnnotationRectTextItem test from running
@nyalldawson nyalldawson added the Chore GitHub and other CI infrastructure changes label Oct 17, 2024
@github-actions github-actions bot added this to the 3.40.0 milestone Oct 17, 2024
Copy link

github-actions bot commented Oct 17, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 6c4e215)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 6c4e215)

@nyalldawson nyalldawson changed the title When excluding tests, only exclude exact matches When excluding tests, only exclude exact matches. Fix some qt 6 tests. Oct 17, 2024
Copy link

Tests failed for Qt 6

One or more tests failed using the build from commit a127048

layout_export

layout_export

Test failed at test_layout_export at tests/src/python/test_selective_masking.py:883

Rendered image did not match tests/testdata/control_images/selective_masking/layout_export/layout_export.png (found 43 pixels different)

layout_export_text_masking_w_transparency

layout_export_text_masking_w_transparency

Test failed at test_layout_export_text_masking_w_transparency at tests/src/python/test_selective_masking.py:1073

Rendered image did not match tests/testdata/control_images/selective_masking/layout_export_text_masking_w_transparency/layout_export_text_masking_w_transparency.png (found 264 pixels different)

layout_export_w_effects

layout_export_w_effects

Test failed at test_layout_export_w_effects at tests/src/python/test_selective_masking.py:920

Rendered image did not match tests/testdata/control_images/selective_masking/layout_export_w_effects/layout_export_w_effects.png (found 320 pixels different)

multiple_label_masks_different_sets_sequential_nocache

multiple_label_masks_different_sets_sequential_nocache

Test failed at test_multiple_label_masks_different_sets at tests/src/python/test_selective_masking.py:422

multiple_label_masks_same_set_sequential_nocache

multiple_label_masks_same_set_sequential_nocache

Test failed at test_multiple_label_masks_same_set at tests/src/python/test_selective_masking.py:461

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

@nyalldawson nyalldawson merged commit f284cc9 into qgis:master Oct 17, 2024
29 checks passed
@nyalldawson nyalldawson deleted the qt6_blocklist branch October 17, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore GitHub and other CI infrastructure changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants