QgsRasterFileWriter::driverForExtension(): make sure querying the tif… #59122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
added a commit
to rouault/QGIS
that referenced
this pull request
Oct 17, 2024
…/tiff extension returns the GTiff driver Not strictly necessary since has been adressed on GDAL side per OSGeo/gdal#11037 but might be prudent for future similar situations. Fixes qgis#59122
rouault
force-pushed
the
fix_59112
branch
2 times, most recently
from
6f68fc6 to
796054f
Compare
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nyalldawson
approved these changes
Oct 17, 2024
| @@ -1072,6 +1072,15 @@ QString QgsRasterFileWriter::driverForExtension( const QString &extension ) | |||
| if ( ext.startsWith( '.' ) ) | |||
| ext.remove( 0, 1 ); | |||
|
|
|||
| if ( ext == QLatin1String( "tif" ) || ext == QLatin1String( "tiff" ) ) | |||
There was a problem hiding this comment.
Shouldn't the comparison be case insensitive?
There was a problem hiding this comment.
indeed. Fixed. Thanks for the review
…/tiff extension returns the GTiff driver Not strictly necessary since has been adressed on GDAL side per OSGeo/gdal#11037 but might be prudent for future similar situations. Fixes qgis#59112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…/tiff extension returns the GTiff driver
Not strictly necessary since has been adressed on GDAL side per OSGeo/gdal#11037 but might be prudent for future similar situations.
Fixes #59112
Already tested per
QGIS/tests/src/python/test_qgsrasterfilewriter.py
Line 108 in 94411b5