[gps] Be tolerant to talker IDs which don't start with 'G' #59124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the nmea specifications it is clear that the talker ID does not have to start with 'G'. Accordingly remove ALL these incorrect hardcoded checks against (a very small subset) of known talker IDs, and permit any two-character string as a valid talker ID Fixes connection to NMEA devices which use "IN" for talker ID (and others)
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
@nyalldawson Test OK Windows Qt6 builds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the nmea specifications it is clear that the talker ID does not have to start with 'G'. Accordingly remove ALL these incorrect hardcoded checks against (a very small subset) of known talker IDs, and permit any two-character string as a valid talker ID
Fixes connection to NMEA devices which use "IN" for talker ID (and others)