Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point cloud editing part 1 #59973

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Point cloud editing part 1 #59973

merged 5 commits into from
Jan 10, 2025

Conversation

uclaros
Copy link
Contributor

@uclaros uclaros commented Dec 19, 2024

Description

This PR kicks off the implementation of qgis/QGIS-Enhancement-Proposals#309

  • QgsPointCloudLayer receives the required methods to start/stop editing and update point attributes.
  • QgsPointCloudEditingIndex is introduced as an editing buffer for point cloud layers holding edits in memory.
  • QgsPointCloudIndex now has a virtual bool updateNodeData() to be overridden by indexes that will support editing. Currently only the QgsPointCloudEditingIndex overrides it for storing edits in memory.
  • No user facing changes yet.

Copy link

github-actions bot commented Dec 19, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 91029c2)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 91029c2)

@uclaros uclaros added API API improvement only, no visible user interface changes and removed Feature labels Dec 20, 2024
@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 4, 2025
@wonder-sk wonder-sk removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 7, 2025
@qgis qgis deleted a comment from github-actions bot Jan 7, 2025
@uclaros uclaros force-pushed the point-cloud-editing branch from a98e5c7 to 2be85ec Compare January 8, 2025 08:00
@wonder-sk wonder-sk merged commit 1f790af into qgis:master Jan 10, 2025
31 checks passed
@uclaros uclaros deleted the point-cloud-editing branch January 10, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API improvement only, no visible user interface changes Point Clouds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants