Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pyqt5to6] store enums to allow usage without QGIS #59992

Closed
wants to merge 2 commits into from
Closed

Conversation

3nids
Copy link
Member

@3nids 3nids commented Dec 21, 2024

This is a first attempt to use this script without QGIS or PyQt6 available.
This would allow to create an easily installable package and create a pre-commit hook so it could be easily integrated to facilitate the transition.

But it seems a bit more complicated than thought.
Especially here:
https://github.com/3nids/qgis-pyqt5to6/blob/7fc059c5a41f7538f39e9ff7ac86a920aa2e315a/pyqt5to6/pyqt5to6.py#L455
https://github.com/3nids/qgis-pyqt5to6/blob/7fc059c5a41f7538f39e9ff7ac86a920aa2e315a/pyqt5to6/pyqt5to6.py#L657-L668

The idea would be to store everything in json files that would be used when QGIS/PyQt6 are not available.
@nyalldawson do you think it's possible in a reasonnable effort to do so?

@github-actions github-actions bot added this to the 3.42.0 milestone Dec 21, 2024
Copy link

github-actions bot commented Dec 21, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 027f55a)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 027f55a)

@nyalldawson
Copy link
Collaborator

@3nids

do you think it's possible in a reasonnable effort to do so

Reasonable? Probably not. It sounds like a worthwhile goal though!! (I can't assist unfortunately.)

Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 10, 2025
Copy link

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants