Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix point cloud refactoring regressions #60064

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

dvdkon
Copy link
Contributor

@dvdkon dvdkon commented Jan 6, 2025

Description

This PR fixes two significant regressions that were introduced by #59279 and #59418:

  • Loading remote COPC files crashed on an assert.
  • Remote EPT layers weren't displayed, since statistics weren't computed.

In the process, I implemented loading QGIS-specific statistics from COPC files over HTTP as well (previously they were only loaded when the file was accessed locally).

@github-actions github-actions bot added this to the 3.42.0 milestone Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 4703c22)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 4703c22)

@agiudiceandrea
Copy link
Contributor

Does this PR fix any already reported issue https://github.com/qgis/QGIS/issues?q=is%3Aopen+is%3Aissue+label%3A%22Point+Clouds%22 or are the fixed issues unreported?

@dvdkon
Copy link
Contributor Author

dvdkon commented Jan 7, 2025

Does this PR fix any already reported issue https://github.com/qgis/QGIS/issues?q=is%3Aopen+is%3Aissue+label%3A%22Point+Clouds%22 or are the fixed issues unreported?

I believe neither of them was reported.

@wonder-sk wonder-sk merged commit fcaba8a into qgis:master Jan 8, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants