-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server empty values in highlight labels parameters #60180
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
Tests failed for Qt 6One or more tests failed using the build from commit 3739adf WMS_GetPrint_Highlight_Empty_LabelsWMS_GetPrint_Highlight_Empty_LabelsTest failed at test_wms_getprint_highlight_empty_labels at tests/src/python/test_qgsserver_wms_getprint.py:557 Rendered image did not match tests/testdata/control_images/qgis_server/WMS_GetPrint_Highlight_Empty_Labels/WMS_GetPrint_Highlight_Empty_Labels.png (found 15210 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
Tests failed for Qt 5One or more tests failed using the build from commit a4d1154 WMS_GetPrint_Highlight_Empty_LabelsWMS_GetPrint_Highlight_Empty_LabelsTest failed at test_wms_getprint_highlight_empty_labels at tests/src/python/test_qgsserver_wms_getprint.py:557 Rendered image did not match tests/testdata/control_images/qgis_server/WMS_GetPrint_Highlight_Empty_Labels/WMS_GetPrint_Highlight_Empty_Labels.png (found 9857 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
If a highlight feature does not have a label, HIGHLIGHT_LABEL_XXX Parameters can be empty, e.g. 'HIGHLIGHT_LABELSTRING=feature1;;feature3'. In the past, empty entries have been discarded when parsing the entry to a list, resulting in assigning the properties to the wrong highlight features. This has been fixed for GetMap and HIGHLIGHT_LABEL_STRING (see #56729), but not for GetPrint and the other label parameters.