Point cloud editing fixes #60237
Point cloud editing fixes #60237
Conversation
uclaros
force-pushed
the
point-cloud-editing-tidyup
branch
from
8b0cdfe to
395652a
Compare
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
| @@ -44,6 +44,7 @@ QgsPointCloudEditingIndex::QgsPointCloudEditingIndex( QgsPointCloudLayer *layer | |||
| mZMax = mIndex.zMax(); | |||
| mRootBounds = mIndex.rootNodeBounds(); | |||
| mSpan = mIndex.span(); | |||
| mFilterExpression = mIndex.subsetString(); | |||
There was a problem hiding this comment.
what if the filter expression changes while we're in editing mode - is this going to be refreshed? I would prefer not to have mFilterExpression here and rather get it when needed from mIndex
| @@ -166,7 +166,7 @@ std::unique_ptr<QgsPointCloudBlock> QgsCopcPointCloudIndex::nodeData( const QgsP | |||
| // we need to create a copy of the expression to pass to the decoder | |||
| // as the same QgsPointCloudExpression object mighgt be concurrently | |||
| // used on another thread, for example in a 3d view | |||
| QgsPointCloudExpression filterExpression = mFilterExpression; | |||
| QgsPointCloudExpression filterExpression = request.ignoreIndexFilterEnabled() ? QgsPointCloudExpression() : mFilterExpression; | |||
There was a problem hiding this comment.
let's implement this for ept point cloud index (just to be sure it respects the api)
| // TODO: apply filtering (if any) | ||
| request.setAttributes( pcIndex.attributes() ); | ||
| request.setAttributes( attributes ); | ||
| request.setIgnoreIndexFilterEnabled( true ); |
There was a problem hiding this comment.
could you please add a comment why we are ignoring the index filter? to get all points so we have the correct point indexes within the node (and it could also go to docstring for setIgnoreIndexFilterEnabled() to clarify when one would want to use it)
Description
This PR fixes point selection for the following cases: