Code refactor: second round

[andrea-pasquale]

No description provided.

[andrea-pasquale]

Further simplification of the code. It should be ready to review now.

[marekgluza]

No action required, comment for the future: for consistency the test function snippet was removed (which is ok)

boostvqe/src/boostvqe/compiling_XXZ.py

Lines 161 to 164 in e108ee4

	def test_compiling_XXZ(t = 0.1, nqubits = 4, steps = 3):
	h = hamiltonians.XXZ(nqubits=nqubits, delta=0.5)
	return np.linalg.norm(h.exp(t) - circuit_compiling_phase(nqubits, steps) * nqubit_XXZ_decomposition(
	nqubits=nqubits,t=0.1,delta=0.5,steps=steps))

In the future we may keep that function in this form for pytest because keeping that phase in this form is crucial for getting a converging norm

[marekgluza]

Thank you very much!!

[andrea-pasquale]

Thanks for the feedback @marekgluza

[marekgluza]

@andrea-pasquale while running checks for proceedings @Sam-XiaoyueLi found probably a bug in kwargs of https://github.com/qiboteam/boostvqe/blob/e5d458d5d591530f24ce87510d90608991c640da/src/boostvqe/models/dbi/double_bracket_evolution_oracles.py#L274C1-L295C10
she'll post an issue in a bit

[andrea-pasquale]

@andrea-pasquale while running checks for proceedings @Sam-XiaoyueLi found probably a bug in kwargs of https://github.com/qiboteam/boostvqe/blob/e5d458d5d591530f24ce87510d90608991c640da/src/boostvqe/models/dbi/double_bracket_evolution_oracles.py#L274C1-L295C10 she'll post an issue in a bit

#68 (comment)

[marekgluza]

thanks a lot @andrea-pasquale

@MatteoRobbiati if you run anything then keep the fixes in this PR in mind :)